Re: pgsql: Fix headerscheck failure in replication/worker_internal.h - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: pgsql: Fix headerscheck failure in replication/worker_internal.h
Date
Msg-id 202111161816.bncq4ckt6ahl@alvherre.pgsql
Whole thread Raw
In response to Re: pgsql: Fix headerscheck failure in replication/worker_internal.h  (Stephen Frost <sfrost@snowman.net>)
Responses Re: pgsql: Fix headerscheck failure in replication/worker_internal.h
Re: pgsql: Fix headerscheck failure in replication/worker_internal.h
List pgsql-hackers
On 2021-Nov-16, Stephen Frost wrote:

> Not against possibly changing that but I don’t get the point of including
> be-gssapi-common.h if it’s not enabled in the build and typically if GSSAPI
> is possible and the reason for including be-gssapi-common.h then there’s
> other things that need to be under a ifdef, again, as in auth.c

BTW, this is exactly why my first suggestion was to add an exclusion
rule to headerscheck so that be-gssapi-common.h is not verified by that
script.  After re-reading your response, that looks like a reasonable
answer too.

-- 
Álvaro Herrera              Valdivia, Chile  —  https://www.EnterpriseDB.com/



pgsql-hackers by date:

Previous
From: Mark Dilger
Date:
Subject: Re: Non-superuser subscription owners
Next
From: Joshua Brindle
Date:
Subject: Re: Support for NSS as a libpq TLS backend