Re: Proposal: Make cfbot fail on patches not created by "git format-patch" - Mailing list pgsql-hackers

From Jacob Champion
Subject Re: Proposal: Make cfbot fail on patches not created by "git format-patch"
Date
Msg-id CAOYmi+kdvgZTpVne+LeZoyuZ43cYrKvhVeBc=9jhhDfTZjn4Ng@mail.gmail.com
Whole thread Raw
In response to Proposal: Make cfbot fail on patches not created by "git format-patch"  (Jelte Fennema-Nio <me@jeltef.nl>)
Responses Re: Proposal: Make cfbot fail on patches not created by "git format-patch"
List pgsql-hackers
On Mon, May 19, 2025 at 6:23 AM Aleksander Alekseev
<aleksander@timescale.com> wrote:
> In my experience people who have been contributing for some time use
> format-patch and provide at least a draft of the commit message,
> because they know it's more convenient both for the reviewers (the
> patch has better chances to be reviewed and tested), and for the
> authors to rebase the patch after a while. Newcomers sometimes submit
> patches that don't even target the `master` branch, and they don't
> know we have cfbot.

While I don't necessarily disagree with these two endpoints, I also
think there are a number of contributors who occupy a spot somewhere
in between -- and there were _many_ people at the unconference session
who were interested in automatically communicating our community norms
in some way. I think that's enough motivation to try something like
Jelte's latest "quality check" proposal.

--Jacob



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Add comment explaining why queryid is int64 in pg_stat_statements
Next
From: Robert Haas
Date:
Subject: Re: Make wal_receiver_timeout configurable per subscription