Postgres Pro
Downloads
Home   >   mailing lists

Re: Shouldn't execParallel.c null-terminate query_string in theparallel DSM? - Mailing list pgsql-hackers

From Rafia Sabih
Subject Re: Shouldn't execParallel.c null-terminate query_string in theparallel DSM?
Date
Msg-id CAOGQiiMfPibwV1cxep2dVxSmHc0H+xC0h5QJgBAD6J14zGAeJA@mail.gmail.com
Whole thread Raw
In response to Shouldn't execParallel.c null-terminate query_string in the parallel DSM?  (Thomas Munro <thomas.munro@enterprisedb.com>)
Responses Re: Shouldn't execParallel.c null-terminate query_string in theparallel DSM?  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Tree view


On Wed, Dec 20, 2017 at 7:58 AM, Thomas Munro <thomas.munro@enterprisedb.com> wrote:
Hi hackers,

I just saw some trailing garbage in my log file emanating from a
parallel worker when my query happened to be a BUFFERALIGNed length
(in this case 64 characters).  Did commit 4c728f382970 forget to make
sure the null terminator is copied?  See attached proposed fix.

Yes, I missed that.
Your patch looks good to me, thanks. 

--
Regards,
Rafia Sabih

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: TRAP: FailedAssertion("!(TransactionIdPrecedesOrEquals
Next
From: Masahiko Sawada
Date:
Subject: Re: User defined data types in Logical Replication