Postgres Pro
Downloads
Home   >   mailing lists

Re: Shouldn't execParallel.c null-terminate query_string in theparallel DSM? - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Shouldn't execParallel.c null-terminate query_string in theparallel DSM?
Date
Msg-id CA+TgmoafX7deorqO8PW+XEj4eXV5F8Sy_9d51PKudFLBWSY11A@mail.gmail.com
Whole thread Raw
In response to Re: Shouldn't execParallel.c null-terminate query_string in theparallel DSM?  (Rafia Sabih <rafia.sabih@enterprisedb.com>)
List pgsql-hackers
Tree view 
On Wed, Dec 20, 2017 at 2:03 AM, Rafia Sabih
<rafia.sabih@enterprisedb.com> wrote:
> On Wed, Dec 20, 2017 at 7:58 AM, Thomas Munro
> <thomas.munro@enterprisedb.com> wrote:
>> I just saw some trailing garbage in my log file emanating from a
>> parallel worker when my query happened to be a BUFFERALIGNed length
>> (in this case 64 characters).  Did commit 4c728f382970 forget to make
>> sure the null terminator is copied?  See attached proposed fix.
>>
> Yes, I missed that.
> Your patch looks good to me, thanks.

Sigh.  I missed that too.  Committed and back-patched to v10.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: David Kamholz
Date:
Subject: Re: domain cast in parameterized vs. non-parameterized query
Next
From: Robert Haas
Date:
Subject: Re: Tracking of page changes for backup purposes. PTRACK [POC]