Re: Allow file inclusion in pg_hba and pg_ident files - Mailing list pgsql-hackers

From Julien Rouhaud
Subject Re: Allow file inclusion in pg_hba and pg_ident files
Date
Msg-id CAOBaU_aysF1t17=x70LBuysTac2FYmoSc5vCqjai=FsT5172+g@mail.gmail.com
Whole thread Raw
In response to Re: Allow file inclusion in pg_hba and pg_ident files  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Tue, Jul 26, 2022 at 1:14 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Tue, Jul 26, 2022 at 01:04:02PM +0800, Julien Rouhaud wrote:
> > It doesn't have much impact most of the time.  The filename is reported if
> > there's an IO error while reading the already opened correct file.  The real
> > problem is if the hba_file and ident_file are stored in different directory,
> > any secondary file (@filename) in the pg_ident.conf would be searched in the
> > wrong directory.  With the pending file inclusion patchset, the problem is
> > immediately visible as the view is reporting the wrong file name.
>
> Oops, obviously.  I'll go and fix that as that's on me.
>
> > Simple fix attached.  I'll add a v15 open item shortly.
>
> Thanks.  Better not to lose track of it.

For the archives's sake, this was fixed shortly after as of
27e0ee57f68d27af68967759a2ff61a581f501dc on master and the open item
is closed.



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Backup command and functions can cause assertion failure and segmentation fault
Next
From: Julien Rouhaud
Date:
Subject: Re: pg_buffercache: add sql test