Re: Collation versioning - Mailing list pgsql-hackers

From Julien Rouhaud
Subject Re: Collation versioning
Date
Msg-id CAOBaU_ZYyxQ3sJR932NFs5HHh++RqXDGwe1S5ubBv8nmsHXCog@mail.gmail.com
Whole thread Raw
In response to Re: Collation versioning  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: Collation versioning  (Thomas Munro <thomas.munro@gmail.com>)
List pgsql-hackers
On Mon, Nov 2, 2020 at 9:04 PM Thomas Munro <thomas.munro@gmail.com> wrote:
>
> On Mon, Nov 2, 2020 at 10:28 PM Julien Rouhaud <rjuju123@gmail.com> wrote:
> > +   /* Remember not to complain about this collation again. */
> > +   context->checked_colls = lappend_oid(context->checked_colls,
> > +                                        otherObject->objectId);
> >
> > It's maybe not immediately obvious that it's safe to save the
> > collation oid at that point, or that it'll always be.  Maybe move it
> > in the if branch above to make it extra clear?
>
> Ok, moved and renamed, and finally pushed.  Thanks for all the help!

\o/  Thanks a lot Thomas!



pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Collation versioning
Next
From: Magnus Hagander
Date:
Subject: Re: pg_upgrade analyze script