Re: Collation versioning - Mailing list pgsql-hackers

From Thomas Munro
Subject Re: Collation versioning
Date
Msg-id CA+hUKGLWDWBL+79jNAz3oMofp1WDjQbBrmZTMe4E-b-MioQU0A@mail.gmail.com
Whole thread Raw
In response to Re: Collation versioning  (Julien Rouhaud <rjuju123@gmail.com>)
Responses Re: Collation versioning  (Julien Rouhaud <rjuju123@gmail.com>)
List pgsql-hackers
On Mon, Nov 2, 2020 at 10:28 PM Julien Rouhaud <rjuju123@gmail.com> wrote:
> +   /* Remember not to complain about this collation again. */
> +   context->checked_colls = lappend_oid(context->checked_colls,
> +                                        otherObject->objectId);
>
> It's maybe not immediately obvious that it's safe to save the
> collation oid at that point, or that it'll always be.  Maybe move it
> in the if branch above to make it extra clear?

Ok, moved and renamed, and finally pushed.  Thanks for all the help!



pgsql-hackers by date:

Previous
From: Andrey Borodin
Date:
Subject: Re: MultiXact\SLRU buffers configuration
Next
From: Julien Rouhaud
Date:
Subject: Re: Collation versioning