Postgres Pro
Downloads
Home   >   mailing lists

Re: postgres_fdw: Minor improvement to postgresAcquireSampleRowsFunc - Mailing list pgsql-hackers

From Julien Rouhaud
Subject Re: postgres_fdw: Minor improvement to postgresAcquireSampleRowsFunc
Date
Msg-id CAOBaU_ZV6MTDDKm+4RJKKUA4WYsgPC9P4cLiB0vjwAsOB-xHcw@mail.gmail.com
Whole thread Raw
In response to postgres_fdw: Minor improvement to postgresAcquireSampleRowsFunc  (Etsuro Fujita <etsuro.fujita@gmail.com>)
Responses Re: postgres_fdw: Minor improvement to postgresAcquireSampleRowsFunc
List pgsql-hackers
Tree view 
On Fri, Jun 28, 2019 at 11:39 AM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
>
> In postgresAcquireSampleRowsFunc, we 1) determine the fetch size and
> then 2) construct the fetch command in each iteration of fetching some
> rows from the remote, but that would be totally redundant.

Indeed.

> Attached
> is a patch for removing that redundancy.

It all looks good to me!  I marked it as ready for committer.

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: allow_system_table_mods stuff
Next
From: Amit Kapila
Date:
Subject: Re: POC: Cleaning up orphaned files using undo logs