Re: postgres_fdw: Minor improvement to postgresAcquireSampleRowsFunc - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: postgres_fdw: Minor improvement to postgresAcquireSampleRowsFunc
Date
Msg-id CAPmGK155Xh9hPkK=2O9vy7kS9yHsSKTVdbnj7ieUhgQ370Ezxg@mail.gmail.com
Whole thread Raw
In response to Re: postgres_fdw: Minor improvement to postgresAcquireSampleRowsFunc  (Julien Rouhaud <rjuju123@gmail.com>)
Responses Re: postgres_fdw: Minor improvement to postgresAcquireSampleRowsFunc
List pgsql-hackers
Hi Julien,

On Fri, Jun 28, 2019 at 6:54 PM Julien Rouhaud <rjuju123@gmail.com> wrote:
> On Fri, Jun 28, 2019 at 11:39 AM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> > In postgresAcquireSampleRowsFunc, we 1) determine the fetch size and
> > then 2) construct the fetch command in each iteration of fetching some
> > rows from the remote, but that would be totally redundant.
>
> Indeed.
>
> > Attached
> > is a patch for removing that redundancy.
>
> It all looks good to me!  I marked it as ready for committer.

Cool!  I'll commit the patch if there are no objections.  Thanks for reviewing!

Best regards,
Etsuro Fujita



pgsql-hackers by date:

Previous
From: Yugo Nagata
Date:
Subject: Re: Implementing Incremental View Maintenance
Next
From: Yugo Nagata
Date:
Subject: Re: Implementing Incremental View Maintenance