Re: Dead code in adminpack - Mailing list pgsql-hackers

From Julien Rouhaud
Subject Re: Dead code in adminpack
Date
Msg-id CAOBaU_Yp3euEyOV-nUOvtwjANYUypJN--RRoevDecRj6khWtNw@mail.gmail.com
Whole thread Raw
In response to Dead code in adminpack  (Antonin Houska <ah@cybertec.at>)
Responses Re: Dead code in adminpack
List pgsql-hackers
On Thu, Feb 13, 2020 at 12:14 PM Antonin Houska <ah@cybertec.at> wrote:
>
> I've noticed that convert_and_check_filename() is always passed false for the
> "logAllowed" argument - someone probably forgot to remove the argument when it
> was decided that log files are no longer accepted. If the argument was removed,
> the function would become a bit simpler, see the patch.

Indeed, and actually I don't see when this codepath was reachable.

Patch LGTM.



pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: table partitioning and access privileges
Next
From: Suraj Kharage
Date:
Subject: Re: allow frontend use of the backend's core hashing functions