Re: Dead code in adminpack - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Dead code in adminpack
Date
Msg-id 20200214034403.GA1998@paquier.xyz
Whole thread Raw
In response to Re: Dead code in adminpack  (Julien Rouhaud <rjuju123@gmail.com>)
List pgsql-hackers
On Thu, Feb 13, 2020 at 12:41:46PM +0100, Julien Rouhaud wrote:
> On Thu, Feb 13, 2020 at 12:14 PM Antonin Houska <ah@cybertec.at> wrote:
>> I've noticed that convert_and_check_filename() is always passed false for the
>> "logAllowed" argument - someone probably forgot to remove the argument when it
>> was decided that log files are no longer accepted. If the argument was removed,
>> the function would become a bit simpler, see the patch.
>
> Indeed, and actually I don't see when this codepath was reachable.
>
> Patch LGTM.

Thanks, applied.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: error context for vacuum to include block number
Next
From: Fujii Masao
Date:
Subject: Re: Wait event that should be reported while waiting for WALarchiving to finish