Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgadmin-hackers] pgAdmin 4 commit: Re-organised the regressiondirectory now we have mul - Mailing list pgadmin-hackers

From Navnath Gadakh
Subject Re: [pgadmin-hackers] pgAdmin 4 commit: Re-organised the regressiondirectory now we have mul
Date
Msg-id CAOAJCYp-PGimqEngnyFfAE0djrMdj2ZLDoH1GbKNqUiuLeNoqg@mail.gmail.com
Whole thread Raw
In response to Re: [pgadmin-hackers] pgAdmin 4 commit: Re-organised the regressiondirectory now we have mul  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgadmin-hackers] pgAdmin 4 commit: Re-organised the regressiondirectory now we have mul  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Tree view
Thanks, It's running now for python2 but failing for python3. Its syntax error 'tuple parameter unpacking not supported in python3'
 In filter function.

Traceback (most recent call last)

  File "runtests.py", line 284, in <module>

    test_module_list = get_test_modules(args)

  File "runtests.py", line 167, in get_test_modules

    TestsGeneratorRegistry.load_generators('pgadmin', exclude_pkgs)

  File "/Users/edb/Navnath/pgadmin4/web/pgadmin/utils/route.py", line 71, in load_generators

    import_module(module_name)

  File "/Users/edb/Navnath/pgenv36/lib/python3.6/importlib/__init__.py", line 126, in import_module

    return _bootstrap._gcd_import(name[level:], package, level)

  File "<frozen importlib._bootstrap>", line 978, in _gcd_import

  File "<frozen importlib._bootstrap>", line 961, in _find_and_load

  File "<frozen importlib._bootstrap>", line 950, in _find_and_load_unlocked

  File "<frozen importlib._bootstrap>", line 655, in _load_unlocked

  File "<frozen importlib._bootstrap_external>", line 674, in exec_module

  File "<frozen importlib._bootstrap_external>", line 781, in get_code

  File "<frozen importlib._bootstrap_external>", line 741, in source_to_code

  File "<frozen importlib._bootstrap>", line 205, in _call_with_frames_removed

  File "/Users/edb/Navnath/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/sql/tests/test_tables_acl.py", line 52

    public_acls = filter(lambda (acl): acl[1] == 'PUBLIC', fetch_result)

                                ^

SyntaxError: invalid syntax 


Will look into it.


On Thu, Mar 23, 2017 at 6:00 PM, Dave Page <dpage@pgadmin.org> wrote:
Update again please. I fixed it a couple of minutes later (I missed a file).

On Thu, Mar 23, 2017 at 12:23 PM, Navnath Gadakh
<navnath.gadakh@enterprisedb.com> wrote:
> Hi Dave,
>
>        I just checked with latest code, test-suite execution failing.
> Showing import errors for test_utils.
> I didn't find test_utils.py under python_test_utils/
>
> Traceback (most recent call last):
>
>   File "runtests.py", line 45, in <module>
>
>     from regression import test_setup
>
>   File "/Users/edb/Navnath/pgadmin4/web/regression/__init__.py", line 10, in
> <module>
>
>     import pgadmin.browser.server_groups.servers.roles.tests.utils as
> roles_utils
>
>   File
> "/Users/edb/Navnath/pgadmin4/web/pgadmin/browser/server_groups/servers/roles/tests/utils.py",
> line 17, in <module>
>
>     from regression.python_test_utils import test_utils as utils
>
> ImportError: cannot import name 'test_utils'
>
>
> I ran test-suite with
> python runtests.py --exclude feature_tests
>
> Please tell me if I missed something.
>
>
> On Thu, Mar 23, 2017 at 5:29 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Re-organised the regression directory now we have multiple test suites:
>> move test_utils.py into python_test_utils/
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>>
>> http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=10920404e146bc4b87100b65fc41ed29ab65e2cd
>> Author: Atira Odhner <aodhner@pivotal.io>
>>
>> Modified Files
>> --------------
>> .../servers/databases/casts/tests/test_cast_add.py |   7 +-
>> .../databases/casts/tests/test_cast_delete.py      |   6 +-
>> .../servers/databases/casts/tests/test_cast_get.py |   9 +-
>> .../servers/databases/casts/tests/test_cast_put.py |   7 +-
>> .../servers/databases/casts/tests/utils.py         |   3 +-
>> .../event_triggers/tests/test_event_trigger_add.py |  12 +-
>> .../tests/test_event_trigger_delete.py             |  10 +-
>> .../event_triggers/tests/test_event_trigger_get.py |  10 +-
>> .../event_triggers/tests/test_event_trigger_put.py |  12 +-
>> .../databases/event_triggers/tests/utils.py        |   3 +-
>> .../extensions/tests/test_extension_add.py         |   7 +-
>> .../extensions/tests/test_extension_delete.py      |   6 +-
>> .../extensions/tests/test_extension_get.py         |   6 +-
>> .../extensions/tests/test_extension_put.py         |   7 +-
>> .../servers/databases/extensions/tests/utils.py    |   3 +-
>> .../tests/test_foreign_servers_add.py              |  11 +-
>> .../tests/test_foreign_servers_delete.py           |   9 +-
>> .../tests/test_foreign_servers_get.py              |   9 +-
>> .../tests/test_foreign_servers_put.py              |  11 +-
>> .../foreign_servers/tests/utils.py                 |   4 +-
>> .../user_mapping/tests/test_user_mapping_add.py    |  15 +-
>> .../user_mapping/tests/test_user_mapping_delete.py |  13 +-
>> .../user_mapping/tests/test_user_mapping_get.py    |  13 +-
>> .../user_mapping/tests/test_user_mapping_put.py    |  15 +-
>> .../foreign_servers/user_mapping/tests/utils.py    |   3 +-
>> .../foreign_data_wrappers/tests/test_fdw_add.py    |   9 +-
>> .../foreign_data_wrappers/tests/test_fdw_delete.py |   9 +-
>> .../foreign_data_wrappers/tests/test_fdw_get.py    |  11 +-
>> .../foreign_data_wrappers/tests/test_fdw_put.py    |  11 +-
>> .../databases/foreign_data_wrappers/tests/utils.py |   5 +-
>> .../databases/languages/tests/test_language_add.py |   7 +-
>> .../languages/tests/test_language_delete.py        |   7 +-
>> .../databases/languages/tests/test_language_get.py |   7 +-
>> .../databases/languages/tests/test_language_put.py |   7 +-
>> .../servers/databases/languages/tests/utils.py     |   3 +-
>> .../schemas/collations/tests/test_collation_add.py |  12 +-
>> .../collations/tests/test_collation_delete.py      |  10 +-
>> .../schemas/collations/tests/test_collation_get.py |  10 +-
>> .../schemas/collations/tests/test_collation_put.py |  12 +-
>> .../databases/schemas/collations/tests/utils.py    |   5 +-
>> .../schemas/domains/tests/test_domain_add.py       |  12 +-
>> .../schemas/domains/tests/test_domain_delete.py    |  10 +-
>> .../schemas/domains/tests/test_domain_get.py       |  10 +-
>> .../schemas/domains/tests/test_domain_put.py       |  12 +-
>> .../databases/schemas/domains/tests/utils.py       |   5 +-
>> .../foreign_tables/tests/test_foreign_table_add.py |  15 +-
>> .../tests/test_foreign_table_delete.py             |  13 +-
>> .../foreign_tables/tests/test_foreign_table_get.py |  13 +-
>> .../foreign_tables/tests/test_foreign_table_put.py |  15 +-
>> .../schemas/foreign_tables/tests/utils.py          |   4 +-
>> .../tests/test_fts_configuration_add.py            |  17 +-
>> .../tests/test_fts_configuration_delete.py         |  11 +-
>> .../tests/test_fts_configuration_get.py            |  11 +-
>> .../tests/test_fts_configuration_put.py            |  13 +-
>> .../schemas/fts_configurations/tests/utils.py      |   6 +-
>> .../tests/test_fts_dictionaries_add.py             |  13 +-
>> .../tests/test_fts_dictionaries_delete.py          |  11 +-
>> .../tests/test_fts_dictionaries_get.py             |  11 +-
>> .../tests/test_fts_dictionaries_put.py             |  13 +-
>> .../schemas/fts_dictionaries/tests/utils.py        |   6 +-
>> .../fts_parser/tests/test_fts_parser_add.py        |  13 +-
>> .../fts_parser/tests/test_fts_parser_delete.py     |  11 +-
>> .../fts_parser/tests/test_fts_parser_get.py        |  11 +-
>> .../fts_parser/tests/test_fts_parser_put.py        |  13 +-
>> .../databases/schemas/fts_parser/tests/utils.py    |   6 +-
>> .../fts_templates/tests/test_fts_templates_add.py  |  13 +-
>> .../tests/test_fts_templates_delete.py             |  11 +-
>> .../fts_templates/tests/test_fts_templates_get.py  |  11 +-
>> .../fts_templates/tests/test_fts_templates_put.py  |  13 +-
>> .../databases/schemas/fts_templates/tests/utils.py |   6 +-
>> .../functions/tests/test_trigger_func_add.py       |  12 +-
>> .../functions/tests/test_trigger_func_delete.py    |  12 +-
>> .../functions/tests/test_trigger_func_get.py       |  12 +-
>> .../functions/tests/test_trigger_func_put.py       |  14 +-
>> .../databases/schemas/functions/tests/utils.py     |   5 +-
>> .../schemas/packages/tests/test_package_add.py     |  14 +-
>> .../schemas/packages/tests/test_package_delete.py  |  12 +-
>> .../schemas/packages/tests/test_package_get.py     |  12 +-
>> .../schemas/packages/tests/test_package_put.py     |  14 +-
>> .../databases/schemas/packages/tests/utils.py      |   5 +-
>> .../schemas/sequences/tests/test_sequence_add.py   |  10 +-
>> .../sequences/tests/test_sequence_delete.py        |  10 +-
>> .../schemas/sequences/tests/test_sequence_get.py   |  10 +-
>> .../schemas/sequences/tests/test_sequence_put.py   |  13 +-
>> .../databases/schemas/sequences/tests/utils.py     |   5 +-
>> .../schemas/synonyms/tests/test_synonym_add.py     |  14 +-
>> .../schemas/synonyms/tests/test_synonym_delete.py  |  12 +-
>> .../schemas/synonyms/tests/test_synonym_get.py     |  12 +-
>> .../schemas/synonyms/tests/test_synonym_put.py     |  18 +-
>> .../databases/schemas/synonyms/tests/utils.py      |   5 +-
>> .../schemas/tables/column/tests/test_column_add.py |  14 +-
>> .../tables/column/tests/test_column_delete.py      |  14 +-
>> .../schemas/tables/column/tests/test_column_get.py |  14 +-
>> .../schemas/tables/column/tests/test_column_put.py |  16 +-
>> .../databases/schemas/tables/column/tests/utils.py |   5 +-
>> .../tests/test_check_constraint_add.py             |  14 +-
>> .../tests/test_check_constraint_delete.py          |  14 +-
>> .../tests/test_check_constraint_get.py             |  14 +-
>> .../tests/test_check_constraint_put.py             |  16 +-
>> .../constraints/check_constraint/tests/utils.py    |   5 +-
>> .../foreign_key/tests/test_foreign_key_add.py      |  14 +-
>> .../foreign_key/tests/test_foreign_key_delete.py   |  14 +-
>> .../foreign_key/tests/test_foreign_key_get.py      |  14 +-
>> .../foreign_key/tests/test_foreign_key_put.py      |  16 +-
>> .../tables/constraints/foreign_key/tests/utils.py  |   5 +-
>> .../tests/test_index_constraint_add.py             |  14 +-
>> .../tests/test_index_constraint_delete.py          |  14 +-
>> .../tests/test_index_constraint_get.py             |  14 +-
>> .../tests/test_index_constraint_put.py             |  16 +-
>> .../constraints/index_constraint/tests/utils.py    |   5 +-
>> .../tables/indexes/tests/test_indexes_add.py       |  14 +-
>> .../tables/indexes/tests/test_indexes_delete.py    |  18 +-
>> .../tables/indexes/tests/test_indexes_get.py       |  18 +-
>> .../tables/indexes/tests/test_indexes_put.py       |  20 +-
>> .../schemas/tables/indexes/tests/utils.py          |   5 +-
>> .../schemas/tables/rules/tests/test_rules_add.py   |  14 +-
>> .../tables/rules/tests/test_rules_delete.py        |  14 +-
>> .../schemas/tables/rules/tests/test_rules_get.py   |  14 +-
>> .../schemas/tables/rules/tests/test_rules_put.py   |  16 +-
>> .../databases/schemas/tables/rules/tests/utils.py  |   5 +-
>> .../templates/column/sql/tests/test_column_acl.py  |   2 +-
>> .../column/sql/tests/test_column_properties.py     |   2 +-
>> .../sql/tests/test_foreign_key_properties.py       |   2 +-
>> .../templates/table/sql/tests/test_tables_acl.py   |   2 +-
>> .../templates/table/sql/tests/test_tables_node.py  |   2 +-
>> .../table/sql/tests/test_tables_properties.py      |   2 +-
>> .../trigger/sql/tests/test_trigger_get_oid.py      |   2 +-
>> .../trigger/sql/tests/test_trigger_nodes.py        |   2 +-
>> .../schemas/tables/tests/test_table_add.py         |  13 +-
>> .../schemas/tables/tests/test_table_delete.py      |  10 +-
>> .../schemas/tables/tests/test_table_get.py         |  10 +-
>> .../schemas/tables/tests/test_table_put.py         |  12 +-
>> .../databases/schemas/tables/tests/utils.py        |   5 +-
>> .../tables/triggers/tests/test_triggers_add.py     |  18 +-
>> .../tables/triggers/tests/test_triggers_delete.py  |  18 +-
>> .../tables/triggers/tests/test_triggers_get.py     |  18 +-
>> .../tables/triggers/tests/test_triggers_put.py     |  20 +-
>> .../schemas/tables/triggers/tests/utils.py         |   5 +-
>> .../databases/schemas/tests/test_schema_add.py     |   6 +-
>> .../databases/schemas/tests/test_schema_delete.py  |   6 +-
>> .../databases/schemas/tests/test_schema_get.py     |   8 +-
>> .../databases/schemas/tests/test_schema_put.py     |   6 +-
>> .../servers/databases/schemas/tests/utils.py       |   5 +-
>> .../schemas/types/tests/test_types_add.py          |  10 +-
>> .../schemas/types/tests/test_types_delete.py       |  10 +-
>> .../schemas/types/tests/test_types_get.py          |  10 +-
>> .../schemas/types/tests/test_types_put.py          |  12 +-
>> .../servers/databases/schemas/types/tests/utils.py |   5 +-
>> .../schemas/views/tests/test_views_add.py          |  12 +-
>> .../schemas/views/tests/test_views_delete.py       |  12 +-
>> .../schemas/views/tests/test_views_get.py          |  12 +-
>> .../schemas/views/tests/test_views_put.py          |  14 +-
>> .../servers/databases/schemas/views/tests/utils.py |   5 +-
>> .../servers/databases/tests/test_db_add.py         |   4 +-
>> .../servers/databases/tests/test_db_delete.py      |   4 +-
>> .../servers/databases/tests/test_db_get.py         |   2 +-
>> .../servers/databases/tests/test_db_put.py         |   2 +-
>> .../server_groups/servers/databases/tests/utils.py |   2 +-
>> .../tests/test_resource_groups_add.py              |   6 +-
>> .../tests/test_resource_groups_delete.py           |   4 +-
>> .../tests/test_resource_groups_put.py              |   6 +-
>> .../tests/tests_resource_groups_get.py             |   4 +-
>> .../servers/resource_groups/tests/utils.py         |   3 +-
>> .../servers/roles/tests/test_role_add.py           |   4 +-
>> .../servers/roles/tests/test_role_delete.py        |   2 +-
>> .../servers/roles/tests/test_role_get.py           |   2 +-
>> .../servers/roles/tests/test_role_put.py           |   2 +-
>> .../server_groups/servers/roles/tests/utils.py     |   7 +-
>> .../servers/tablespaces/tests/test_tbspc_add.py    |   5 +-
>> .../servers/tablespaces/tests/test_tbspc_delete.py |   5 +-
>> .../servers/tablespaces/tests/test_tbspc_get.py    |   4 +-
>> .../servers/tablespaces/tests/test_tbspc_put.py    |   2 +-
>> .../servers/tablespaces/tests/utils.py             |   5 +-
>> .../connect/sql/tests/test_check_recovery.py       |   2 +-
>> .../server_groups/servers/tests/test_server_add.py |   2 +-
>> .../servers/tests/test_server_delete.py            |   2 +-
>> .../server_groups/servers/tests/test_server_get.py |   2 +-
>> .../server_groups/servers/tests/test_server_put.py |   3 +-
>> .../browser/server_groups/servers/tests/utils.py   |   2 +-
>> web/pgadmin/browser/tests/test_change_password.py  |   4 +-
>> web/pgadmin/browser/tests/test_login.py            |   3 +-
>> web/pgadmin/browser/tests/test_logout.py           |   2 +-
>> web/pgadmin/browser/tests/test_reset_password.py   |   4 +-
>> .../connect_to_server_feature_test.py              |   2 +-
>> .../feature_tests/table_ddl_feature_test.py        |   2 +-
>> .../python_test_utils/template_helper.py           |   9 +
>> web/regression/runtests.py                         |   2 +-
>> web/regression/test_utils.py                       | 455
>> ---------------------
>> 188 files changed, 871 insertions(+), 1254 deletions(-)
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>
>
>
> --
> Regards,
> Navnath Gadakh
>
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Regards,
Navnath Gadakh

EnterpriseDB Corporation
The Enterprise PostgreSQL Company


pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: [pgadmin-hackers] Javascript translations
Next
From: Dave Page
Date:
Subject: [pgadmin-hackers] pgAdmin 4 commit: Fix Python 3 compatibility.