Postgres Pro
Downloads
Home   >   mailing lists

Fixed crash in debugger with wxWidget 3.0 - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Fixed crash in debugger with wxWidget 3.0
Date
Msg-id CANxoLDfeVy=jPG_a833Kb2Xh=9oJ9LmDYA3T5iC2a+ZBZt6-dg@mail.gmail.com
Whole thread Raw
Responses Re: Fixed crash in debugger with wxWidget 3.0  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Tree view
Hi Dave 

During testing of pgAdmin3 with wxWidget 3.0, I have found one crash in debugger. Cause of the crash is "m_progress" variable is not instantiated before the function call "wxStatusBar::SetFieldsCount(fields);" at line no 49 in ctlProgressStatusBar.cpp.

Function call "wxStatusBar::SetFieldsCount(fields)" internally calls "ctlProgressStatusBar::SetStatusWidths" which internally calls "ctlProgressStatusBar::OnSize" and that time "m_progress" variable is not instantiated, but used that's why application got crashed.

I have just moved up  the call to instantiate the "m_progress" variable. Attached is the patch file to fix the issue. Please review it and if it looks good to you then can you please commit the code. 

--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Attachment

pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: PATCH: wxWidgets 3.0 Data dir
Next
From: Dave Page
Date:
Subject: pgAdmin III commit: Fix a crash bug in the config editor.