Postgres Pro
Downloads
Home   >   mailing lists

Re: Fixed crash in debugger with wxWidget 3.0 - Mailing list pgadmin-hackers

From Dave Page
Subject Re: Fixed crash in debugger with wxWidget 3.0
Date
Msg-id CA+OCxoxBr5HheSeG+=U0_2MXtys2xfkooe5FbQb-Ob0-Jk37+A@mail.gmail.com
Whole thread Raw
In response to Fixed crash in debugger with wxWidget 3.0  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Tree view
Thanks - applied.


On Fri, May 23, 2014 at 9:05 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Dave 

During testing of pgAdmin3 with wxWidget 3.0, I have found one crash in debugger. Cause of the crash is "m_progress" variable is not instantiated before the function call "wxStatusBar::SetFieldsCount(fields);" at line no 49 in ctlProgressStatusBar.cpp.

Function call "wxStatusBar::SetFieldsCount(fields)" internally calls "ctlProgressStatusBar::SetStatusWidths" which internally calls "ctlProgressStatusBar::OnSize" and that time "m_progress" variable is not instantiated, but used that's why application got crashed.

I have just moved up  the call to instantiate the "m_progress" variable. Attached is the patch file to fix the issue. Please review it and if it looks good to you then can you please commit the code. 

--
Akshay Joshi
Principal Software Engineer 




--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin III commit: Fix a potential crash in the debugger.
Next
From: Dave Page
Date:
Subject: pgAdmin III commit: Correctly initialise the datadir variable when usin