Home > mailing lists

[pgAdmin4][Patch]: RM #3232 Backup with incorrect path stays inbroken state - Mailing list pgadmin-hackers

From	Akshay Joshi
Subject	[pgAdmin4][Patch]: RM #3232 Backup with incorrect path stays inbroken state
Date	October 19, 2018 16:30:29
Msg-id	CANxoLDfA_ycCJaDrTve+5jDS3nc_Y9R+mXG_gQ1yPWqGFOxkyA@mail.gmail.com Whole thread Raw
Responses	Re: [pgAdmin4][Patch]: RM #3232 Backup with incorrect path stays inbroken state (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
List	pgadmin-hackers

Hi Hackers,

I have fixed RM #3232 Backup with incorrect path stays in broken state. Attached patch file contains following:

Fix for RM #3232, in case user provide wrong path then "Backup/Restore/Maintenance/ImportExport" utility won't start and user will get an pop up for file not found.
Correct the logic for "Backup/Restore/Maintenance/ImportExport" test cases, it is failing when default binary path is not set in the test_config.json file. It should be skipped if path not provided.
Skip all the test cases for "Backup/Restore/Maintenance/ImportExport" if respective utility files are not found on the given path.
Added "Stop Process" button to stop the Utility("Backup/Restore/Maintenance/ImportExport") process. To support this I used "psutil" python package to terminate the process. psutil is a cross platform package.
Modify Jasmin test cases.

I have tested the patch on OSX, Linux and Windows. Please review it.

Akshay Joshi

Sr. Software Architect

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

From: Akshay Joshi
Date: 18 October 2018, 15:33:57
Subject: pgAdmin 4 commit: Fixed issue where session files are not deletedfirst

From: aman gupta
Date: 22 October 2018, 08:56:44
Subject: Optimizing Postgresql ILIKE while query