Re: [pgAdmin][RM5519]: Unable to close tab after disconnecting server. - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin][RM5519]: Unable to close tab after disconnecting server.
Date
Msg-id CANxoLDf9OxBbMB7TQvyNtwNDn5SjyZUNYNCDkgX34DL9S4Mrmw@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin][RM5519]: Unable to close tab after disconnecting server.  (Pradip Parkale <pradip.parkale@enterprisedb.com>)
List pgadmin-hackers
Thanks, patch applied.

On Thu, Apr 1, 2021 at 11:40 AM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Hackers,

Please find the updated patch with the change mentioned by Dave.

On Wed, Mar 31, 2021 at 7:53 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks Pradip.

Before this is committed, let's change this:

gettext('Current trasaction is not commited because server is disconnected.'),

to:

gettext('The current transaction has been rolled back because the server was disconnected.'),

On Wed, Mar 31, 2021 at 3:09 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Hackers,
Please find the attached patch for #5519. Updated the existing confirmation message and also added a new confirmation dialog before closing the query tool if the server is disconnected.

--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com



--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Ensure that the query tool tab should be closed after
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Fixed feature tests.