Re: [pgAdmin][RM5519]: Unable to close tab after disconnecting server. - Mailing list pgadmin-hackers

From Pradip Parkale
Subject Re: [pgAdmin][RM5519]: Unable to close tab after disconnecting server.
Date
Msg-id CAJ9T6SvVw-Q1M-baSPc6tzvoO7q+em39Pq=bzeb869gEDMLM4Q@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin][RM5519]: Unable to close tab after disconnecting server.  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgAdmin][RM5519]: Unable to close tab after disconnecting server.  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Hi Hackers,

Please find the updated patch with the change mentioned by Dave.

On Wed, Mar 31, 2021 at 7:53 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks Pradip.

Before this is committed, let's change this:

gettext('Current trasaction is not commited because server is disconnected.'),

to:

gettext('The current transaction has been rolled back because the server was disconnected.'),

On Wed, Mar 31, 2021 at 3:09 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Hackers,
Please find the attached patch for #5519. Updated the existing confirmation message and also added a new confirmation dialog before closing the query tool if the server is disconnected.

--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com



--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation
Attachment

pgadmin-hackers by date:

Previous
From: Steve Chavez
Date:
Subject: Re: CLI for Schema Diff
Next
From: Yogesh Mahajan
Date:
Subject: Feature Test Fix