Postgres Pro
Downloads
Home   >   mailing lists

Re: Patch for SonarQube code scan fixes. - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: Patch for SonarQube code scan fixes.
Date
Msg-id CANxoLDeMg5nqxnKM_H3j3cVLGFJEzB4Dtrm6rqUBDLA4PJQ+Bg@mail.gmail.com
Whole thread Raw
In response to Patch for SonarQube code scan fixes.  (Nikhil Mohite <nikhil.mohite@enterprisedb.com>)
List pgadmin-hackers
Tree view
Thanks, patch applied. I haven't committed changes for "sqlautocomplete/parseutils", as Dave suggested send the patch to pgcli.

On Tue, Sep 8, 2020 at 2:59 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Team,

I have fixed some code smell issues in the SonarQube scan, PFA patch.
Details as follows:

1. psycopg2/connection:
  • Refactor this function to reduce its Cognitive Complexity from 32 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed.
2. psycopg2/server_manager:
  • Refactor this function to reduce its Cognitive Complexity from 20 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 33 to the 15 allowed.
  • Refactor this function to reduce its Cognitive Complexity from 26 to the 15 allowed.
3. sqlautocomplete/parseutils:
  • Refactor this function to reduce its Cognitive Complexity from 23 to the 15 allowed.


--
Thanks & Regards,
Nikhil Mohite
Software Engineer.
Mob.No: +91-7798364578.


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin][SonarQube] Reduce cognitive complexity
Next
From: Aditya Toshniwal
Date:
Subject: Re: [pgAdmin][RM5794] Excessive CPU usage while browser is idle