Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin][SonarQube] Reduce cognitive complexity - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin][SonarQube] Reduce cognitive complexity
Date
Msg-id CANxoLDfxtdR04OjvbjaxJjGQ4nCwSS+7kW6GM5a457b34s27Lw@mail.gmail.com
Whole thread Raw
In response to [pgAdmin][SonarQube] Reduce cognitive complexity  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
List pgadmin-hackers
Tree view
Thanks, patch applied.

On Tue, Sep 8, 2020 at 6:13 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Attached patch reduces the cognitive complexity as below:
web/pgadmin/tools/sqleditor/utils/is_begin_required.py - 89 to 15
web/pgadmin/utils/driver/psycopg2/connection.py - 16 to 15
web/setup.py - 17 to 15

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Fixed cognitive complexity issues reported by SonarQu
Next
From: Akshay Joshi
Date:
Subject: Re: Patch for SonarQube code scan fixes.