Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgadmin4][Patch]: Feature #3273 Add ability to sort in theSelect File window when opening a saved query - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgadmin4][Patch]: Feature #3273 Add ability to sort in theSelect File window when opening a saved query
Date
Msg-id CANxoLDeEccXUAjFhEpzrywqYpLoOB+tzgRqr4ROA_1A4Nyhzgg@mail.gmail.com
Whole thread Raw
In response to Re: [pgadmin4][Patch]: Feature #3273 Add ability to sort in theSelect File window when opening a saved query  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgadmin4][Patch]: Feature #3273 Add ability to sort in theSelect File window when opening a saved query  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Tree view


On Thu, Jun 21, 2018 at 6:20 AM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Jun 20, 2018 at 3:13 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch for Feature #3273 Add ability to sort in the Select File window when opening a saved query.

I haven't seen any refactoring possibility, patch contains feature test with time.sleep(0.05). I have spend lot of time to not introduce "time.sleep()" and tried couple of different ways of WebDriveWait, but didn't get success. 

Please review it.

I get the following running the feature tests:

invalid syntax (xss_checks_file_manager_test.py, line 60)

make: *** [check-feature] Error 1


   Fixed.
 
Also; should that file be renamed now, to reflect that it tests more than just XSS? 

    Done. Attached is the modified patch. 


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Attachment

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [pgadmin4][Patch]: Feature #3273 Add ability to sort in theSelect File window when opening a saved query
Next
From: Akshay Joshi
Date:
Subject: [pgadmin4][Patch]: Fixed minor issue in auto discover server whenentry is blank in the config file