Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgadmin4][Patch]: Feature #3273 Add ability to sort in theSelect File window when opening a saved query - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgadmin4][Patch]: Feature #3273 Add ability to sort in theSelect File window when opening a saved query
Date
Msg-id CA+OCxoxkuv7863HAB10fxUeJUezDBSNW4awos6-eDgK9-_UZkw@mail.gmail.com
Whole thread Raw
In response to [pgadmin4][Patch]: Feature #3273 Add ability to sort in the SelectFile window when opening a saved query  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Responses Re: [pgadmin4][Patch]: Feature #3273 Add ability to sort in theSelect File window when opening a saved query  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi

On Wed, Jun 20, 2018 at 3:13 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch for Feature #3273 Add ability to sort in the Select File window when opening a saved query.

I haven't seen any refactoring possibility, patch contains feature test with time.sleep(0.05). I have spend lot of time to not introduce "time.sleep()" and tried couple of different ways of WebDriveWait, but didn't get success. 

Please review it.

I get the following running the feature tests:

invalid syntax (xss_checks_file_manager_test.py, line 60)

make: *** [check-feature] Error 1


Also; should that file be renamed now, to reflect that it tests more than just XSS? 


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Aditya Toshniwal
Date:
Subject: Re: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.
Next
From: Akshay Joshi
Date:
Subject: Re: [pgadmin4][Patch]: Feature #3273 Add ability to sort in theSelect File window when opening a saved query