Re: Fix in switch cell tab navigation - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: Fix in switch cell tab navigation
Date
Msg-id CANxoLDdreG4TecTxirN=_d7XaD0qpV_bd5Lc9+j8VFbnZrsH1w@mail.gmail.com
Whole thread Raw
In response to Re: Fix in switch cell tab navigation  (Ganesh Jaybhay <ganesh.jaybhay@enterprisedb.com>)
List pgadmin-hackers
Thanks, patch applied.

On Thu, Mar 26, 2020 at 10:30 AM Ganesh Jaybhay <ganesh.jaybhay@enterprisedb.com> wrote:
Hi Khushboo,

I have removed the condition added for subgrid-cell. Please find the attached updated patch

Regards,
Ganesh Jaybhay

On Wed, Mar 25, 2020 at 5:39 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Ganesh,

You have put a check on subgrid-cell class, which does not exist in the entire source code.
Also, can you please let me know of any module which you have tested, so I can test accordingly though the code for the same looks good to me.

Thanks,
Khushboo


On Wed, Mar 25, 2020 at 3:21 PM Ganesh Jaybhay <ganesh.jaybhay@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch for below minor fix in the switch cell tab navigation:

After pressing the tab key on switch cell, sometimes focus doesn't go to the immediate next editable cell. It goes to the different cell for fraction of seconds and again comes to the next editable cell.

Please review.

Regards,
Ganesh Jaybhay


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Fixed an issue where focus doesn't go to the immediat
Next
From: Nagesh Dhope
Date:
Subject: Re: [pgAdmin][RM5292] Alertify header buttons focus color issue