Re: [pgAdmin][RM5292] Alertify header buttons focus color issue - Mailing list pgadmin-hackers

From Nagesh Dhope
Subject Re: [pgAdmin][RM5292] Alertify header buttons focus color issue
Date
Msg-id CAA3zdZomS+itkbYcqs7pLocKyyipWAOVfC+ZQXE45+iLDoHw7A@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin][RM5292] Alertify header buttons focus color issue  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Responses Re: [pgAdmin][RM5292] Alertify header buttons focus color issue  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Please find an updated patch, which fixes review comments.

On Thu, Mar 26, 2020 at 10:24 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Nagesh,

I cannot see any change related to $active-border variable apart from !default. Plus, $active-border should not be allowed to edit. It is a structural variable and not a variable which affects theme change.
Please revert the $active-border change and send the patch.

On Thu, Mar 26, 2020 at 10:14 AM Nagesh Dhope <nagesh.dhope@enterprisedb.com> wrote:
Hi Hackers,

Please find a patch which includes
  1. Use btn-secondary styles for all buttons in alertify dialog header.
  2. Added !default for $active-border variable, so that it can be overridden if required. 
  3. Added entry for .scss in .editorconfig
--
Thanks,
Nagesh


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks,
Nagesh
Attachment

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: Fix in switch cell tab navigation
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Added support of Domain, Domain Constraints and Types