Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin][RM5292] Alertify header buttons focus color issue - Mailing list pgadmin-hackers

From Aditya Toshniwal
Subject Re: [pgAdmin][RM5292] Alertify header buttons focus color issue
Date
Msg-id CAM9w-_k2LJh7Cf2ycX+mOdn0kutea0Yy8EBLryza7HyepXkiZA@mail.gmail.com
Whole thread Raw
In response to [pgAdmin][RM5292] Alertify header buttons focus color issue  (Nagesh Dhope <nagesh.dhope@enterprisedb.com>)
Responses Re: [pgAdmin][RM5292] Alertify header buttons focus color issue  (Nagesh Dhope <nagesh.dhope@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Nagesh,

I cannot see any change related to $active-border variable apart from !default. Plus, $active-border should not be allowed to edit. It is a structural variable and not a variable which affects theme change.
Please revert the $active-border change and send the patch.

On Thu, Mar 26, 2020 at 10:14 AM Nagesh Dhope <nagesh.dhope@enterprisedb.com> wrote:
Hi Hackers,

Please find a patch which includes
  1. Use btn-secondary styles for all buttons in alertify dialog header.
  2. Added !default for $active-border variable, so that it can be overridden if required. 
  3. Added entry for .scss in .editorconfig
--
Thanks,
Nagesh


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

pgadmin-hackers by date:

Previous
From: Nagesh Dhope
Date:
Subject: [pgAdmin][RM5292] Alertify header buttons focus color issue
Next
From: Ganesh Jaybhay
Date:
Subject: Re: Fix in switch cell tab navigation