Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin][RM5050] Language node code coverage. - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin][RM5050] Language node code coverage.
Date
Msg-id CANxoLDdajm+q_+P0wO-0-NXCkonH=FKpoW8qnpTR4h1-MFKA+Q@mail.gmail.com
Whole thread Raw
In response to [pgAdmin][RM5050] Language node code coverage.  (Pradip Parkale <pradip.parkale@enterprisedb.com>)
Responses Re: [pgAdmin][RM5050] Language node code coverage.  (Pradip Parkale <pradip.parkale@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Pradip

Below are the review comments:
  • Format the JSON file. Rename the JSON file from 'language_testcases.json' to 'language_test_data.json'.
  • For consistency please follow the naming convention used in 'cast_test_data.json' file. For example, in Cast we have used 'name' and in Languages, we used 'Test_case'.
  • Move all the data in the JSON file from python file.
  • Move mocking function name and return value to the JSON file, as we did in 'cast_test_data.json' file.
  • Move "generate_scenarios" function to "web/regression/python_test_utils/test_utils.py"
Can you please fix the following for CAST node:
  • Remove 'TC-..' from all the scenario name.
  • Used the same generic function(generate_scenario) from test_utils.


On Wed, Jan 15, 2020 at 2:19 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi All,

Attached is a patch for language node code coverage.
This increases the code coverage of the language node from 45% to 69%.

Command to run the tests -
        - python runtests.py --pkg browser.server_groups.servers.databases.languages.tests


--
Thanks & Regards,
Pradip Parkale
QMG, EnterpriseDB Corporation


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: RM5049 Patch
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Updated the incorrect icon used for the cast node on