Postgres Pro
Downloads
Home   >   mailing lists

Re: RM5049 Patch - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: RM5049 Patch
Date
Msg-id CANxoLDfpYqkkcfSQTtNC77KcJweFZ+ZS6=99-FeeEbpWfk9otQ@mail.gmail.com
Whole thread Raw
In response to Re: RM5049 Patch  (Yogesh Mahajan <yogesh.mahajan@enterprisedb.com>)
List pgadmin-hackers
Tree view
Thanks, patch applied with some modification as verify cast logic is not working.

On Wed, Jan 15, 2020 at 2:45 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:
Hi,

Please find updated patch -


Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


On Wed, Jan 15, 2020 at 1:49 PM Neel Patel <neel.patel@enterprisedb.com> wrote:
Patch only covers removal of the code and change in "coveragerc.in". I guess you missed to add the new files in the patch. Can you please verify ?

Thanks,
Neel Patel

On Wed, Jan 15, 2020 at 1:16 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com> wrote:
Hi,

Please find attached patch for  api tests for cast node.This covers -
Added new file (cast_test_cases.json) storing inventory, test, expected data.
Also covers test cases for all cast node related api,
This increase code coverage for cast from 33% to 68%.

Command to run tests - 
--pkg browser.server_groups.servers.databases.casts.tests

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin][RM5096] Replace node-sass with sass for SCSS compilation
Next
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin][RM5050] Language node code coverage.