Postgres Pro
Downloads
Home   >   mailing lists

[pgAdmin4][Patch]: RM #3277 Runtime startup error handling is brokenon Windows. - Mailing list pgadmin-hackers

From Akshay Joshi
Subject [pgAdmin4][Patch]: RM #3277 Runtime startup error handling is brokenon Windows.
Date
Msg-id CANxoLDcBHYpsK3+ijxh-xXKnPbe39iMZpk4QyMHE5VYahqAw=Q@mail.gmail.com
Whole thread Raw
Responses Re: [pgAdmin4][Patch]: RM #3277 Runtime startup error handling isbroken on Windows.
List pgadmin-hackers
Tree view
Hi Hackers,

Please find the attached patch to fix RM #3277 Runtime startup error handling is broken on Windows.

This issue is regression of RM #3177 "Sporadically crashes on Windows when exit". Where below code of pgAdmin4.cpp creates the problem:
QObject::connect(server, SIGNAL(finished()), server, SLOT(deleteLater()));

In case when PythonPath is not provided then application server not started and server thread finished there execution, due to the above line of code Destructor of Server class has been called and we are accessing the function server->getError().length() at line no 251 of pgAdmin4.cpp, which cause the application crash.

I have removed that line and tested RM #3177 and RM# 3277, both are working fine.

Please review and test it.

--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Attachment

pgadmin-hackers by date:

Previous
From: Xuri Gong
Date:
Subject: GSoC Introduction - Implement geospatial data viewer in pgAdmin4 for PostGIS
Next
From: Dave Page
Date:
Subject: Re: [pgAdmin4][Patch]: RM #3277 Runtime startup error handling isbroken on Windows.