Postgres Pro
Downloads
Home   >   mailing lists

Re: PATCH: FTS configuration node - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: PATCH: FTS configuration node
Date
Msg-id CANxoLDcAYhKC2TH_ZGwioTRYQY7Da+Jkq__-OrGWJ958WddQ2A@mail.gmail.com
Whole thread Raw
In response to Re: PATCH: FTS configuration node  (Sanket Mehta <sanket.mehta@enterprisedb.com>)
Responses Re: PATCH: FTS configuration node  (Sanket Mehta <sanket.mehta@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Sanket 

Below are my review comments:

  • Add button should be disabled in Tokens tab while creating.
  • Unable to click on down arrow for token select control. 
  • Title should be change from "Create FTS-dictionaries" to "Create FTS-Configuration".
  • Tree node is not getting refreshed on name change.
  • Unable to rename FTS Configuration when name contains any capital letter.
  • If user tries to add already existing token then respective row in the backgrid should be highlighted.
  • "URL not found" when click on SQL help icon from the properties dialog.
  • SQL should not be generated when remove and add the same token again. Currently it is creating two sql's one for remove and another is for add.
    • Fix for the above issue is: - Add "keys: ['token']," to TokenModel in your js file.

On Fri, May 13, 2016 at 2:58 PM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:
Hi All,

Last patch for FTS configuration does not contain node.ui.js file
Kindly ignore it.

Here is the new revised patch attached with this mail.
Please do review it and let me know if any changes required

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Thu, May 12, 2016 at 4:38 PM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:
Hi,

PFA the revised patch.
Please do review it and let me know if anything is not proper.

Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Thu, May 5, 2016 at 8:19 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

-- 
Harshal Dhumal
Software Engineer 




On Thu, May 5, 2016 at 8:18 PM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:
Hi,

PFA first patch for FTS configuration node.

It depends upon backgrid select2cell multi select control, for which Harshal has sent the patch recently.
Please do apply his patch first and then apply this patch.

Please do review it and let me know if any changes are required.


Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers






--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: Re: PATCH: Initiale backup utility [pgAdmin4]
Next
From: Sandeep Thakkar
Date:
Subject: Re: Patch for pgAdmin4 package on Mac OS X