On Fri, 18 Nov 2022 at 20:26, Thomas Munro <thomas.munro@gmail.com> wrote:
>
> On Sat, Nov 19, 2022 at 7:54 AM Simon Riggs
> <simon.riggs@enterprisedb.com> wrote:
> > I agree. I can't see a reason to keep it anymore.
>
> + Use of <varname>promote_trigger_file</varname> is deprecated. If you're
>
> I think 'deprecated' usually implies that it still works but you
> should avoid it. I think you need something stronger.
Whisky? Or maybe just reword the sentence...
New version attached.
> > I'm nervous about not having any wakeup at all, but since we are
> > removing the parameter there is no other reason not to do as Andres
> > suggests.
>
> Why? If we're accidentally relying on this timeout for recovery to
> not hang in some situation, that's a bug waiting to be discovered and
> fixed and it won't be this patch's fault.
>
> > New version attached, which assumes that the SIGALRMs are silenced on
> > the other thread.
>
> I tested this + Bharath's v5 from the other thread. meson test
> passes, and tracing the recovery process shows that it is indeed,
> finally, completely idle. Huzzah!
Thanks for testing!
Finally completely idle? Good to achieve that.
--
Simon Riggs http://www.EnterpriseDB.com/
