RULE regression test fragility? - Mailing list pgsql-hackers

From Mike Blackwell
Subject RULE regression test fragility?
Date
Msg-id CANPAkgunoTdgoJEvagr-+Rd0ABtbjywybYBnY6gNs7f_1HkaJw@mail.gmail.com
Whole thread Raw
Responses Re: RULE regression test fragility?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
While reviewing the Network Stats Traffic patch I discovered the current regression test for rules depends on the system view definitions not changing:

--
-- Check that ruleutils are working
--
SELECT viewname, definition FROM pg_views WHERE schemaname <> 'information_schema' ORDER BY viewname;


In this particular case new fields have been added to the view, breaking this apparently unrelated test.  Is checking the definition of all views necessary for this test?  Would it possibly be better to create a temporary view for this check, or is something else going on here? 

​​
__________________________________________________________________________________
Mike Blackwell | Technical Analyst, Distribution Services/Rollout Management | RR Donnelley
1750 Wallace Ave | St Charles, IL 60174-3401
Office: 630.313.7818
Mike.Blackwell@rrd.com
http://www.rrdonnelley.com


pgsql-hackers by date:

Previous
From: Sameer Kumar
Date:
Subject: Re: Using indexes for ORDER BY and PARTITION BY clause in windowing functions
Next
From: Josh Berkus
Date:
Subject: Re: Commitfest II CLosed