Re: [HACKERS] Should we cacheline align PGXACT? - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: [HACKERS] Should we cacheline align PGXACT?
Date
Msg-id CANP8+jLK3rM0eQkAxQSLFN=qaJs0=ijp9yBW9bRUWnFAFaFNjQ@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Should we cacheline align PGXACT?  (Ashutosh Sharma <ashu.coek88@gmail.com>)
Responses Re: [HACKERS] Should we cacheline align PGXACT?  (Ashutosh Sharma <ashu.coek88@gmail.com>)
List pgsql-hackers
On 1 March 2017 at 04:50, Ashutosh Sharma <ashu.coek88@gmail.com> wrote:
On Tue, Feb 28, 2017 at 11:44 PM, Simon Riggs <simon@2ndquadrant.com> wrote:
On 28 February 2017 at 11:34, Ashutosh Sharma <ashu.coek88@gmail.com> wrote:
 
So, Here are the pgbench results I got with 'reduce_pgxact_access_AtEOXact.v2.patch' on a read-write workload.

Thanks for performing a test.

I see a low yet noticeable performance gain across the board on that workload.

That is quite surprising to see a gain on that workload. The main workload we have been discussing was the full read-only test (-S). For that case the effect should be much more noticeable based upon Andres' earlier comments.

Would it be possible to re-run the test using only the -S workload? Thanks very much.

Okay, I already had the results for read-oly workload but just forgot to share it along with the results for read-write test. Here are the results for read-only
test,

Thanks for conducting those comparisons.

So we have variable and sometimes significant gains, with no regressions.

By the shape of the results this helps in different places to the alignment patch. Do we have evidence to commit both?

--
Simon Riggs                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Jan Michálek
Date:
Subject: Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki
Next
From: David Rowley
Date:
Subject: [HACKERS] Patch to improve performance of replay of AccessExclusiveLock