Re: Optimising compactify_tuples() - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: Optimising compactify_tuples()
Date
Msg-id CANP8+jK8LkN1PsY6+dHRYVdzRAW5i1C2Q_rBUHsyPD_v41HCcg@mail.gmail.com
Whole thread Raw
In response to Re: Optimising compactify_tuples()  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: Optimising compactify_tuples()  (Robert Haas <robertmhaas@gmail.com>)
Re: Optimising compactify_tuples()  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
On Thu, 10 Sep 2020 at 14:45, David Rowley <dgrowleyml@gmail.com> wrote:

> I've also attached another tiny patch that I think is pretty useful
> separate from this. It basically changes:
>
> LOG:  redo done at 0/D518FFD0
>
> into:
>
> LOG:  redo done at 0/D518FFD0 system usage: CPU: user: 58.93 s,
> system: 0.74 s, elapsed: 62.31 s
>
> (I was getting sick of having to calculate the time spent from the log
> timestamps.)

I really like this patch, thanks for proposing it.

Should pg_rusage_init(&ru0);
be at the start of the REDO loop, since you only use it if we take that path?

-- 
Simon Riggs                http://www.2ndQuadrant.com/
Mission Critical Databases



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: recovering from "found xmin ... from before relfrozenxid ..."
Next
From: Robert Haas
Date:
Subject: Re: Optimising compactify_tuples()