Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Avoid pin scan for replay of XLOG_BTREE_VACUUM - Mailing list pgsql-committers

From Simon Riggs
Subject Re: pgsql: Avoid pin scan for replay of XLOG_BTREE_VACUUM
Date
Msg-id CANP8+jJnGm71gd+HZZQ-GYepRV1nsqXsdJc842MmvcOzoOaw3g@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Avoid pin scan for replay of XLOG_BTREE_VACUUM  (Andres Freund <andres@anarazel.de>)
Responses Re: pgsql: Avoid pin scan for replay of XLOG_BTREE_VACUUM  (Andres Freund <andres@anarazel.de>)
List pgsql-committers
Tree view
On 9 January 2016 at 12:23, Andres Freund <andres@anarazel.de> wrote:
Hi,

On 2016-01-09 10:13:27 +0000, Simon Riggs wrote:
> src/backend/access/rmgrdesc/nbtdesc.c |    2 +-

I've not reviewed the patch, but a very quick glance during a rebase
with conflicts showed:

@@ -48,7 +48,7 @@ btree_desc(StringInfo buf, XLogReaderState *record)
            {
                xl_btree_vacuum *xlrec = (xl_btree_vacuum *) rec;

-               appendStringInfo(buf, "lastBlockVacuumed %u",
+               appendStringInfo(buf, "lastBlockVacuumed %d",
                                 xlrec->lastBlockVacuumed);
                break;
            }

which doesn't look right?

It's right. New value of -1 allowed in that field, so change required to allow it to display properly for debug.

--
Simon Riggs                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pgsql: Avoid pin scan for replay of XLOG_BTREE_VACUUM
Next
From: Tom Lane
Date:
Subject: pgsql: Add STRICT to some C functions created by the regression tests.