Re: pgsql: Avoid pin scan for replay of XLOG_BTREE_VACUUM - Mailing list pgsql-committers

From Andres Freund
Subject Re: pgsql: Avoid pin scan for replay of XLOG_BTREE_VACUUM
Date
Msg-id 20160109122355.ydzn4n5wwhe7objs@alap3.anarazel.de
Whole thread Raw
In response to pgsql: Avoid pin scan for replay of XLOG_BTREE_VACUUM  (Simon Riggs <simon@2ndQuadrant.com>)
Responses Re: pgsql: Avoid pin scan for replay of XLOG_BTREE_VACUUM  (Simon Riggs <simon@2ndQuadrant.com>)
List pgsql-committers
Hi,

On 2016-01-09 10:13:27 +0000, Simon Riggs wrote:
> src/backend/access/rmgrdesc/nbtdesc.c |    2 +-

I've not reviewed the patch, but a very quick glance during a rebase
with conflicts showed:

@@ -48,7 +48,7 @@ btree_desc(StringInfo buf, XLogReaderState *record)
            {
                xl_btree_vacuum *xlrec = (xl_btree_vacuum *) rec;

-               appendStringInfo(buf, "lastBlockVacuumed %u",
+               appendStringInfo(buf, "lastBlockVacuumed %d",
                                 xlrec->lastBlockVacuumed);
                break;
            }

which doesn't look right?



pgsql-committers by date:

Previous
From: Simon Riggs
Date:
Subject: pgsql: Avoid pin scan for replay of XLOG_BTREE_VACUUM
Next
From: Simon Riggs
Date:
Subject: Re: pgsql: Avoid pin scan for replay of XLOG_BTREE_VACUUM