Postgres Pro
Downloads
Home   >   mailing lists

Re: Needless additional partition check in INSERT? - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: Needless additional partition check in INSERT?
Date
Msg-id CANP8+j+iM9pBLvd-O8hBodqmjAQjYg-+cR0QwATYqods9-u1Ww@mail.gmail.com
Whole thread Raw
In response to Re: Needless additional partition check in INSERT?  (David Rowley <david.rowley@2ndquadrant.com>)
Responses Re: Needless additional partition check in INSERT?  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Re: Needless additional partition check in INSERT?  (David Rowley <david.rowley@2ndquadrant.com>)
List pgsql-hackers
Tree view 
On 10 May 2018 at 05:33, David Rowley <david.rowley@2ndquadrant.com> wrote:
> On 10 May 2018 at 16:13, Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> wrote:
>> The patch to ExecInsert looks good, but I think we also need to do the
>> same thing in CopyFrom.
>
> I think so too.
>
> Updated patch attached.

Patch is good.

The cause of this oversight is the lack of comments to explain the
original coding, so we need to correct that in this patch, please.

-- 
Simon Riggs                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Pavan Deolasee
Date:
Subject: PANIC during crash recovery of a recently promoted standby
Next
From: Hubert Zhang
Date:
Subject: Considering signal handling in plpython again