Re: [PATCH] Add regression tests of ecpg command notice (error / warning) - Mailing list pgsql-hackers

From Ryo Kanbayashi
Subject Re: [PATCH] Add regression tests of ecpg command notice (error / warning)
Date
Msg-id CANOn0ExSbtNEM6zO5oZzcwJ-QWLQ7Q9HqbL-kux+niKQ5fce9A@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Add regression tests of ecpg command notice (error / warning)  (Fujii Masao <masao.fujii@oss.nttdata.com>)
Responses Re: [PATCH] Add regression tests of ecpg command notice (error / warning)
List pgsql-hackers
>On Mon, Mar 3, 2025 at 12:23 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
> On 2025/03/01 19:45, Ryo Kanbayashi wrote:
> >> +program_help_ok('ecpg');
> >> +program_version_ok('ecpg');
> >> +program_options_handling_ok('ecpg');
> >> +command_fails(['ecpg'], 'ecpg without arguments fails');
> >>
> >> These checks seem unnecessary in 002 since they're already covered in 001.
> >
> > I reflected above.
>
> Thanks for updating the patch!
>
> I've made some minor fixes and cosmetic adjustments.
> The updated patch is attached.
>
> Unless there are any objections, I'll commit it.

Thanks for reviewing and adustments.
There is no objections :)

---
Great regards,
Ryo Kanbayashi
NTT Open Source Software Center



pgsql-hackers by date:

Previous
From: Jacob Brazeal
Date:
Subject: Re: Accidental assignment instead of compare in GetOperatorFromCompareType?
Next
From: Michael Paquier
Date:
Subject: Re: [PATCH] pg_stat_activity: make slow/hanging authentication more visible