Re: [PATCH] Add regression tests of ecpg command notice (error / warning) - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: [PATCH] Add regression tests of ecpg command notice (error / warning)
Date
Msg-id 716c896f-99c7-49c3-a4ec-90441448eeb2@oss.nttdata.com
Whole thread Raw
In response to Re: [PATCH] Add regression tests of ecpg command notice (error / warning)  (Ryo Kanbayashi <kanbayashi.dev@gmail.com>)
Responses Re: [PATCH] Add regression tests of ecpg command notice (error / warning)
List pgsql-hackers

On 2025/03/01 19:45, Ryo Kanbayashi wrote:
>> +program_help_ok('ecpg');
>> +program_version_ok('ecpg');
>> +program_options_handling_ok('ecpg');
>> +command_fails(['ecpg'], 'ecpg without arguments fails');
>>
>> These checks seem unnecessary in 002 since they're already covered in 001.
> 
> I reflected above.

Thanks for updating the patch!

I've made some minor fixes and cosmetic adjustments.
The updated patch is attached.

Unless there are any objections, I'll commit it.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Attachment

pgsql-hackers by date:

Previous
From: Junwang Zhao
Date:
Subject: Re: Make COPY format extendable: Extract COPY TO format implementations
Next
From: Amit Kapila
Date:
Subject: Re: [Patch] add new parameter to pg_replication_origin_session_setup