Re: [PATCH] We install pg_regress and isolationtester but not pg_isolation_regress - Mailing list pgsql-hackers

From Craig Ringer
Subject Re: [PATCH] We install pg_regress and isolationtester but not pg_isolation_regress
Date
Msg-id CAMsr+YHvzLbXffAUcMNQDdui9GHHT1+kqOwyknQ5Yw7aebfKpA@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] We install pg_regress and isolationtester but not pg_isolation_regress  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: [PATCH] We install pg_regress and isolationtester but not pg_isolation_regress
List pgsql-hackers

On Tue, 29 Sep 2020 at 22:09, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
On 2018-Jun-01, Craig Ringer wrote:

> On 28 May 2018 at 15:06, Craig Ringer <craig@2ndquadrant.com> wrote:
>
> > Per topic, the Pg makefiles install pg_regress (for use by extensions) and
> > htey install the isolationtester, but they don't install
> > pg_isolation_regress.
> >
> > We should install it too.

I happened to come across this thread by accident, and I tend to agree
that we need to install both isolationtester and pg_isolation_regress to
the pgxs dirs, just like we do pg_regress.  I can't find that
isolationtester is installed anywhere though; maybe that changed after
you posted this.  Anyway, this version of the patch installs both.

Thanks.

I think rules were added to allow the isolation tester to be installed with an explicit make -C src/test/isolation install, but not added to the default "install" target.

I agree it should just be installed.

--
 Craig Ringer                   http://www.2ndQuadrant.com/
 2ndQuadrant - PostgreSQL Solutions for the Enterprise

pgsql-hackers by date:

Previous
From: Greg Nancarrow
Date:
Subject: Re: Parallel INSERT (INTO ... SELECT ...)
Next
From: "David G. Johnston"
Date:
Subject: NOTIFY docs fixup - emit and deliver consistency