Andres Freund <andres@anarazel.de> writes: > On 2018-03-01 14:09:02 +0100, Fabien COELHO wrote: >>> A bit concerned that we're turning pgbench into a kitchen sink.
>> I do not understand "kitchen sink" expression in this context, and your >> general concerns about pgbench in various comments in your message.
> We're adding a lot of stuff to pgbench that only a few people > use. There's a lot of duplication with similar parts of code in other > parts of the codebase. pgbench in my opinion is a tool to facilitate > postgres development, not a goal in itself.
FWIW, I share Andres' concern that pgbench is being extended far past what anyone has shown a need for. If we had infinite resources this wouldn't be a big problem, but it's eating into limited committer hours and I'm not really convinced that we're getting adequate return.
I have similar worries about us growing an ad-hoc scripting language in psql.
