Re: pg_receivexlog: spurious error message connecting to 9.3 - Mailing list pgsql-hackers

From Craig Ringer
Subject Re: pg_receivexlog: spurious error message connecting to 9.3
Date
Msg-id CAMsr+YGN+SkBAnthtfqVvEo7Qh2shDN4Z=mjS1p4JG-rfha8VQ@mail.gmail.com
Whole thread Raw
In response to pg_receivexlog: spurious error message connecting to 9.3  (Marco Nenciarini <marco.nenciarini@2ndquadrant.it>)
Responses Re: pg_receivexlog: spurious error message connecting to 9.3  (Marco Nenciarini <marco.nenciarini@2ndquadrant.it>)
Re: pg_receivexlog: spurious error message connecting to 9.3  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On 10 November 2015 at 01:47, Marco Nenciarini
<marco.nenciarini@2ndquadrant.it> wrote:

> I've attached a little patch that removes the errors when connected to 9.3.

Looks good to me. No point confusing users.

The other callers of RunIdentifySystem are pg_basebackup and
pg_receivelogical.

pg_basebackup doesn't ask for the db_name (passes null).

pg_receivelogical handles it being null already (and if it didn't,
it'd die with or without this patch).

pg_receivexlog expects it to be null and fails gracefully if it isn't.

So this change just removes some pointless noise.

-- Craig Ringer                   http://www.2ndQuadrant.com/PostgreSQL Development, 24x7 Support, Training & Services



pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: Re: can we add SKIP LOCKED to UPDATE?
Next
From: Amit Kapila
Date:
Subject: Re: storage/buffer/README docs about buffer replacement are out of date