Re: [PATCH] Skip llvm bytecode generation if LLVM is missing - Mailing list pgsql-hackers

From Craig Ringer
Subject Re: [PATCH] Skip llvm bytecode generation if LLVM is missing
Date
Msg-id CAMsr+YFxmebADet3AERsQL7HakOXOzKzdsRKaZbfoqKoko9QmQ@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Skip llvm bytecode generation if LLVM is missing  (Andres Freund <andres@anarazel.de>)
Responses Re: [PATCH] Skip llvm bytecode generation if LLVM is missing  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
List pgsql-hackers
On Fri, 13 Mar 2020 at 15:04, Andres Freund <andres@anarazel.de> wrote:
On 2020-03-13 14:08:12 +0800, Craig Ringer wrote:
> The alternative would be to detect a missing clang and emit a much more
> informative error than the current one that explicitly suggests retrying
> with
>
>     make with_llvm=no
>
> or setting with_llvm=no in the environment.

That, that, that's what I suggested upthread?

Yes, and I still don't like it. "with_llvm" is the actual already-working option. I'd rather make this not randomly explode for users, but failing that we can just hack the Makefile in the rpms for EL-7 (where it's a particular mess) and rely on an error message for other cases.

--
 Craig Ringer                   http://www.2ndQuadrant.com/
 2ndQuadrant - PostgreSQL Solutions for the Enterprise

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Additional improvements to extended statistics
Next
From: Thomas Munro
Date:
Subject: Re: Additional improvements to extended statistics