Re: [PATCH] Logical decoding support for sequence advances - Mailing list pgsql-hackers

From Craig Ringer
Subject Re: [PATCH] Logical decoding support for sequence advances
Date
Msg-id CAMsr+YFv5oFnk=1qkSoCeSGPRiO742Lh8CWB4DPsdA3nSth-=A@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Logical decoding support for sequence advances  (Petr Jelinek <petr@2ndquadrant.com>)
Responses Re: [PATCH] Logical decoding support for sequence advances
List pgsql-hackers
On 1 March 2016 at 05:30, Petr Jelinek <petr@2ndquadrant.com> wrote:

On 29/02/16 03:23, Craig Ringer wrote:
 
Sound reasonable?

I wonder if it would be acceptable to create new info flag for RM_SEQ_ID that would behave just like XLOG_SEQ_LOG but would be used only for the nontransactional updates (nextval) so that decoding could easily differentiate between transactional and non-transactional update of sequence and then just either call the callback immediately or add the change to reorder buffer based on that. The redo code could just have simple OR expression to behave same with both of the info flags.

That's much cleaner than trying to keep track of sequence creations and really pretty harmless. I'll give that a go and see how it looks.
 
Seems like simpler solution than building all the tracking code on the decoding side to me.

+1

--
 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [REVIEW]: Password identifiers, protocol aging and SCRAM protocol
Next
From: Tom Lane
Date:
Subject: Re: TAP / recovery-test fs-level backups, psql enhancements etc