Re: Improve GetConfigOptionValues function - Mailing list pgsql-hackers

From Nitin Jadhav
Subject Re: Improve GetConfigOptionValues function
Date
Msg-id CAMm1aWZY38naak+RiG9XvOGEVa+NJ=Y0YYHnzEHdSSVDh0OfHw@mail.gmail.com
Whole thread Raw
In response to Improve GetConfigOptionValues function  (Nitin Jadhav <nitinjadhavpostgres@gmail.com>)
Responses Re: Improve GetConfigOptionValues function
List pgsql-hackers
Attaching the patch.

On Wed, Jan 18, 2023 at 1:21 PM Nitin Jadhav
<nitinjadhavpostgres@gmail.com> wrote:
>
> Hi,
>
> GetConfigOptionValues function extracts the config parameters for the
> given variable irrespective of whether it results in noshow or not.
> But the parent function show_all_settings ignores the values parameter
> if it results in noshow. It's unnecessary to fetch all the values
> during noshow. So a return statement in GetConfigOptionValues() when
> noshow is set to true is needed. Attached the patch for the same.
> Please share your thoughts.
>
> Thanks & Regards,
> Nitin Jadhav

Attachment

pgsql-hackers by date:

Previous
From: Nitin Jadhav
Date:
Subject: Improve GetConfigOptionValues function
Next
From: "Drouvot, Bertrand"
Date:
Subject: Re: Helper functions for wait_for_catchup() in Cluster.pm