Postgres Pro
Downloads
Home   >   mailing lists

Improve GetConfigOptionValues function - Mailing list pgsql-hackers

From Nitin Jadhav
Subject Improve GetConfigOptionValues function
Date
Msg-id CAMm1aWYgfekpRK-Jz5=pM_bV+Om=ktGq1vxTZ_dr1Z6MV-qokA@mail.gmail.com
Whole thread Raw
Responses Re: Improve GetConfigOptionValues function
Re: Improve GetConfigOptionValues function
List pgsql-hackers
Tree view 
Hi,

GetConfigOptionValues function extracts the config parameters for the
given variable irrespective of whether it results in noshow or not.
But the parent function show_all_settings ignores the values parameter
if it results in noshow. It's unnecessary to fetch all the values
during noshow. So a return statement in GetConfigOptionValues() when
noshow is set to true is needed. Attached the patch for the same.
Please share your thoughts.

Thanks & Regards,
Nitin Jadhav

pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Deduplicate logicalrep_read_tuple()
Next
From: Nitin Jadhav
Date:
Subject: Re: Improve GetConfigOptionValues function