Deduplicate logicalrep_read_tuple() - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Deduplicate logicalrep_read_tuple()
Date
Msg-id CALj2ACXdbq7kW_+bRrSGMsR6nefCvwbHBJ5J51mr3gFf7QysTA@mail.gmail.com
Whole thread Raw
Responses Re: Deduplicate logicalrep_read_tuple()
List pgsql-hackers
Hi,

logicalrep_read_tuple() duplicates code for LOGICALREP_COLUMN_TEXT and
LOGICALREP_COLUMN_BINARY introduced by commit 9de77b5. While it
doesn't hurt anyone, deduplication makes code a bit leaner by 57 bytes
[1]. I've attached a patch for $SUBJECT.

Thoughts?

[1] size ./src/backend/replication/logical/proto.o
PATCHED:
   text    data     bss     dec     hex filename
  15558       0       0   15558    3cc6
./src/backend/replication/logical/proto.o

HEAD:
   text    data     bss     dec     hex filename
  15615       0       0   15615    3cff
./src/backend/replication/logical/proto.o

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachment

pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: Allow logical replication to copy tables in binary format
Next
From: Nitin Jadhav
Date:
Subject: Improve GetConfigOptionValues function