[HACKERS] execGrouping.c limit on work_mem - Mailing list pgsql-hackers

From Jeff Janes
Subject [HACKERS] execGrouping.c limit on work_mem
Date
Msg-id CAMkU=1yRMzPkxhEd2EOdPakSFC2ryvEy=-akCE53nY+JezHb1Q@mail.gmail.com
Whole thread Raw
Responses Re: [HACKERS] execGrouping.c limit on work_mem  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
In BuildTupleHashTable


    /* Limit initial table size request to not more than work_mem */
    nbuckets = Min(nbuckets, (long) ((work_mem * 1024L) / entrysize));


Is this a good idea?  If the caller of this code has no respect for work_mem, they are still going to blow it out of the water.  Now we will just do a bunch of hash-table splitting in the process.  That is only going to add to the pain.

Also:

* false if it existed already.  ->additional_data in the new entry has

The field is just ->additional, not ->additional_data

Cheers,

Jeff

pgsql-hackers by date:

Previous
From: Jeff Janes
Date:
Subject: [HACKERS] simplehash.h typo
Next
From: Michael Paquier
Date:
Subject: Re: [HACKERS] logical replication and PANIC during shutdowncheckpoint in publisher