Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Race condition in logical walsender causes longpostgresql shutdown delay - Mailing list pgsql-hackers

From Jeff Janes
Subject Re: [PATCH] Race condition in logical walsender causes longpostgresql shutdown delay
Date
Msg-id CAMkU=1xd2w6OmgHb_fCQW3-gHOswAEThqgkbZ=WLU_qbcok4Lg@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Race condition in logical walsender causes longpostgresql shutdown delay  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: [PATCH] Race condition in logical walsender causes longpostgresql shutdown delay
List pgsql-hackers
Tree view
On Wed, Sep 11, 2019 at 3:52 PM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:

Reading over this code, I noticed that the detection of the catch-up
state ends up being duplicate code, so I would rework that function as
in the attached patch.

The naming of those flags (got_SIGUSR2, got_STOPPING) is terrible, but
I'm not going to change that in a backpatchable bug fix.

Hi Alvaro, does this count as a review?  And Craig, do you agree with Alvaro's patch as a replacement for your own?
 
Thanks,

Jeff

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Optimize partial TOAST decompression
Next
From: Amit Kapila
Date:
Subject: Re: range test for hash index?