Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Race condition in logical walsender causes longpostgresql shutdown delay - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [PATCH] Race condition in logical walsender causes longpostgresql shutdown delay
Date
Msg-id 20190911195233.GA3904@alvherre.pgsql
Whole thread Raw
In response to Re: [PATCH] Race condition in logical walsender causes longpostgresql shutdown delay  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: [PATCH] Race condition in logical walsender causes longpostgresql shutdown delay
List pgsql-hackers
Tree view 
On 2019-Sep-03, Alvaro Herrera wrote:

> On 2019-Jul-25, Craig Ringer wrote:
> 
> > Patch attached.
> 
> Here's a non-broken version of this patch.  I have not done anything
> other than reflowing the new comment.

Reading over this code, I noticed that the detection of the catch-up
state ends up being duplicate code, so I would rework that function as
in the attached patch.

The naming of those flags (got_SIGUSR2, got_STOPPING) is terrible, but
I'm not going to change that in a backpatchable bug fix.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachment

pgsql-hackers by date:

Previous
From: Nino Floris
Date:
Subject: Re: [PATCH] ltree, lquery, and ltxtquery binary protocol support
Next
From: Fabien COELHO
Date:
Subject: Re: psql - improve test coverage from 41% to 88%