Re: [HACKERS] uninterruptible state in 10beta4 - Mailing list pgsql-hackers

From Jeff Janes
Subject Re: [HACKERS] uninterruptible state in 10beta4
Date
Msg-id CAMkU=1wgDapzw2vvWs92385zK1jvHz6SSybBMsChmMBZOEsKrA@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] uninterruptible state in 10beta4  (Andres Freund <andres@anarazel.de>)
Responses Re: [HACKERS] uninterruptible state in 10beta4  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Wed, Sep 13, 2017 at 2:41 PM, Andres Freund <andres@anarazel.de> wrote:
Hi,

On 2017-09-13 14:28:34 -0700, Jeff Janes wrote:
> In 10beta4 and 11dev, If I run the below it enters an uninterruptible
> state.  After the insert starts, I give 15 or seconds or so until the
> memory usage starts to grow due to enqueued triggers checks. Then I can't
> interrupt it with either ctrl-C in psql or kill -15 <pid> from another
> terminal.
>
> I have to do kill -9 <pid>
>
> create table foo  (x int);
> create or replace function notice () returns trigger as $$ begin raise
> notice 'asdfsdf'; return NEW; END;$$ language plpgsql;
> create trigger foobar after insert on foo for each row execute procedure
> notice();
> insert into foo select * from generate_series(1,100000000);
>
> Git bisect lays the blame here which certainly seems plausible:
>
> commit d47cfef7116fb36349949f5c757aa2112c249804
> Author: Andres Freund <andres@anarazel.de>
> Date:   Tue Jul 25 17:37:17 2017 -0700
>
>     Move interrupt checking from ExecProcNode() to executor nodes.

Indeed that seems plausible. I guess something like the attached should
fix the issue?

Yep, that fixes it.

Thanks,

Jeff

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [HACKERS] uninterruptible state in 10beta4
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] uninterruptible state in 10beta4