Re: Allowing line-continuation in pgbench custom scripts - Mailing list pgsql-hackers

From Jeff Janes
Subject Re: Allowing line-continuation in pgbench custom scripts
Date
Msg-id CAMkU=1wLSMBDY0YoxZH+weMS3Mjm6d1YphPoFi4jjAo10k0Yig@mail.gmail.com
Whole thread Raw
In response to Re: Allowing line-continuation in pgbench custom scripts  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Allowing line-continuation in pgbench custom scripts
List pgsql-hackers
On Monday, May 26, 2014, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Amit Langote <amitlangote09@gmail.com> writes:
> In a custom pgbench script, it seems convenient to be able to split a
> really long query to span multiple lines using an escape character
> (bash-style). Attached adds that capability to read_line_from_file()
> in pgbench.c

This seems pretty likely to break existing scripts that happen to contain
backslashes.  Is it really worth the compatibility risk?

Do you mean due to the bugs you point out, or in general?  Is it really at all likely that someone has ended a line of their custom benchmark file with a backslash?  I'm having a hard time seeing what, other than malice, would prod someone to do that.

Cheers,

Jeff

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [PATCH] Replacement for OSSP-UUID for Linux and BSD
Next
From: Matteo Beccati
Date:
Subject: Re: [PATCH] Replacement for OSSP-UUID for Linux and BSD